Fix inheritance of ambientocclusion property from parent model by Uiniel · Pull Request #729 · BlueMap-Minecraft/BlueMap

Uiniel · 2025-08-11T11:00:46Z

I only noticed this bug because I encountered a similar bug (with a more noticeable property) in BlueMapModelLoaders.

A simple test with the following resource pack:

assets/minecraft/models/block/pink_wool.json :

{
  "parent": "minecraft:block/cube_all",
  "ambientocclusion": "false",
  "textures": {
    "all": "minecraft:block/pink_wool"
  }
}

assets/minecraft/models/block/white_wool.json :

{
  "parent": "minecraft:block/pink_wool",
  "textures": {
    "all": "minecraft:block/white_wool"
  }
}

assets/minecraft/models/block/light_gray_wool.json :

{
  "parent": "minecraft:block/pink_wool",
  "ambientocclusion": "true",
  "textures": {
    "all": "minecraft:block/light_gray_wool"
  }
}

Before:

After:

Fix inheritance of ambientocclusion property from parent model

252b0e5

TBlueF approved these changes Aug 11, 2025

View reviewed changes

TBlueF merged commit 3df7836 into BlueMap-Minecraft:master Aug 11, 2025
2 checks passed

Provide feedback