Fix stringToWide sizing, main signature, and timeout fallback#102
Merged
Easton97-Jens merged 2 commits intoApr 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MultiByteToWideChar(); make the multithread example use a standards-compliantmainsignature; and make the stress test portable on systems missing thetimeoututility.Description
src/operators/inspect_file.ccallocateneededwide characters, callMultiByteToWideChar()with capacityneeded, verify the returned written count matchesneeded, and remove the trailing null viapop_back()to preserve previous behavior while fixing the sizing risk.examples/multithread/multithread.ccchange the program entry signature fromint main(int argc, const char *argv[])toint main(int argc, char *argv[])without changing how arguments are used.test/stress/inspectfile_multithread_stress.shkeep usingtimeoutexactly as before when available, and otherwise print a clear warning and run the same command withouttimeout.Testing
git diff --checkwhich completed with no issues detected.sh -n test/stress/inspectfile_multithread_stress.shwhich succeeded.Codex Task