core: adapt trace engine i18n functions to LH i18n model #16365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Mar 4, 2025
| static localizeInsights(insightSets) { | ||
| static localizeFunction(str_, fn) { | ||
| return (...args) => this.localize(str_, fn(...args)); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
localizeFunction is pretty much the only addition to this file. Everything else is shuffling code around.
adamraine
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor/follow-up of #16364
We should have the ability to re-use functionality from TE, even if it deals with localizing strings. This PR adds the ability to do that.
ref #16323