Fix: Storybook setup#1033
Merged
Merged
Conversation
801c5fb to
86bafa8
Compare
mohdsayed
reviewed
Apr 16, 2025
Comment on lines
+165
to
+167
| "dependencies": { | ||
| "npm": "^11.2.0", | ||
| "run": "^1.5.0" |
Collaborator
There was a problem hiding this comment.
What is the purpose of it?
Contributor
Author
There was a problem hiding this comment.
the storybook installer added them, but I am not fully sure why, I will check if this is really needed
Contributor
Author
There was a problem hiding this comment.
Actually, not really sure why this is there, probably a typo while installing deps. Anyways, I removed it and works fine.
mohdsayed
approved these changes
Apr 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Storybook and make sure there are no vulnerabilites with dependencies
Testing Instructions
fix/storybook-setupnpm install && npm run storybookChecklist