Fix: Multiple rows getting selected with the same event time#1041
Merged
Conversation
Contributor
|
@mayan-000 This would truly "random"? Need to keep timing realism into account (i.e. sequential events, reasonable space between events, etc.) |
Collaborator
Author
@amedina Yes, the randomness added is reasonable, which mimics actual event timing. The gap we are using for min and max is based on actual events. |
mohdsayed
approved these changes
Apr 14, 2025
mohdsayed
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now thanks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multiple rows with the same event time are selected in auction table. This PR fixes the same event time for multiple rows in PA EE and updates the logic to add unique random numbers during calculation.
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
This code is covered by unit tests to verify that it works as intended.Fixes #