Skip to content

Fix: Auction removal timing#1044

Merged
mohdsayed merged 3 commits into
release/v0.14.1from
fix/auction-data-removal
Apr 14, 2025
Merged

Fix: Auction removal timing#1044
mohdsayed merged 3 commits into
release/v0.14.1from
fix/auction-data-removal

Conversation

@CharliePops

@CharliePops CharliePops commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

Description

Remove auction data from bottom panel (auction tab) when the current action flow is finished

Testing Instructions

  1. Pull and checkout the branch fix/auction-data-removal
  2. Build and run the extension: npm run build:all && npm run dev:ext
  3. Open Privacy Sandbox tab on DevTools
  4. Go to Private Advertising -> Protected Audience -> Explorable explanations
  5. Play the animation
  6. Observe: when there is an auction, the bottom panel gets populated
  7. Observe: the panel stays populated until the current auction flow is finished (see screencast)

Screenshot/Screencast

step-delay.mp4

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops self-assigned this Apr 14, 2025
@CharliePops CharliePops marked this pull request as ready for review April 14, 2025 09:01
@CharliePops CharliePops added this to the v0.14.1 milestone Apr 14, 2025
@CharliePops CharliePops requested a review from mohdsayed April 14, 2025 09:25
@mohdsayed mohdsayed merged commit 98bddd3 into release/v0.14.1 Apr 14, 2025
@mohdsayed mohdsayed deleted the fix/auction-data-removal branch April 14, 2025 11:44
@mohdsayed mohdsayed mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants