Skip to content

Fix: Prevent auto scrolling when animation is paused in EE#1048

Merged
mohdsayed merged 1 commit into
release/v0.14.1from
fix/paused-scrolling
Apr 16, 2025
Merged

Fix: Prevent auto scrolling when animation is paused in EE#1048
mohdsayed merged 1 commit into
release/v0.14.1from
fix/paused-scrolling

Conversation

@CharliePops

@CharliePops CharliePops commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes scrolling when animation is paused

Relevant Technical Choices

Never scroll if the autoscroll is disable or animation paused

Testing Instructions

  1. Pull and checkout the branch fix/paused-scrolling
  2. Build and run the extension: npm run build:all && npm run dev:ext
  3. Open Privacy Sandbox tab on DevTools
  4. Go PA:EE
  5. Enable auto scroll
  6. Wait for a winning app to show up
  7. Pause the animation
  8. Observer, the animation doesn't trigger any scrolling

Screenshot/Screencast

scroll.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops self-assigned this Apr 15, 2025
@CharliePops CharliePops added this to the v0.14.1 milestone Apr 15, 2025
@CharliePops CharliePops marked this pull request as ready for review April 15, 2025 15:59
@mohdsayed mohdsayed changed the title Fix: Paused scrolling Fix: Prevent auto scrolling when animation is paused in EE Apr 16, 2025
@mohdsayed mohdsayed merged commit c78d774 into release/v0.14.1 Apr 16, 2025
@mohdsayed mohdsayed deleted the fix/paused-scrolling branch April 16, 2025 08:31
@mohdsayed mohdsayed mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants