Skip to content

Fix: Panel cards borders#1057

Merged
mohdsayed merged 1 commit into
release/v0.14.1from
fix/cards-borders
Apr 22, 2025
Merged

Fix: Panel cards borders#1057
mohdsayed merged 1 commit into
release/v0.14.1from
fix/cards-borders

Conversation

@CharliePops

@CharliePops CharliePops commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

Description

  • Improve cads UI by adding better contrast in the border, adding color and slightly increasing border width

Testing Instructions

  1. Pull and checkout the branch fix/cards-borders
  2. Build and run the extension: npm run build:all && npm run dev:ext
  3. Open Privacy Sandbox tab on DevTools
  4. Go any landing page that contains cards: Dashboard, Learning, Tracking Protection, Private Advertising, Site Boundaries
  5. Observe that the cards have a colored border and they look consistent in all pages

Screenshot/Screencast

  • Light theme:
Screenshot 2025-04-17 at 10 51 27 AM
  • Dark theme:
Screenshot 2025-04-17 at 10 51 04 AM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [NA] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops mentioned this pull request Apr 22, 2025
3 tasks
@CharliePops CharliePops marked this pull request as ready for review April 22, 2025 11:59
@CharliePops CharliePops self-assigned this Apr 22, 2025
@mohdsayed mohdsayed added this to the v0.14.1 milestone Apr 22, 2025
@mohdsayed mohdsayed merged commit e937a00 into release/v0.14.1 Apr 22, 2025
@mohdsayed mohdsayed deleted the fix/cards-borders branch April 22, 2025 14:14
@mohdsayed mohdsayed mentioned this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants