Skip to content

Refactor: Split content script into functional parts#1065

Merged
mohdsayed merged 1 commit into
developfrom
ref/split-content-script
May 2, 2025
Merged

Refactor: Split content script into functional parts#1065
mohdsayed merged 1 commit into
developfrom
ref/split-content-script

Conversation

@amovar18

@amovar18 amovar18 commented May 2, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR aims to split content script into functional parts.

Relevant Technical Choices

  • The PR splits the content script into 2 parts, one part will be used for frame overlay functionality another part is used to detect js cookies in all the frames.

Testing Instructions

  • Verify that frameoverlay works as intended and JS cookie detection works as intended.

Additional Information:

  • This PR is a work to integrate some more functionality in the PSAT extension.

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Add separate js cookie inject into all frames.
@amovar18 amovar18 self-assigned this May 2, 2025
@amovar18 amovar18 requested a review from mohdsayed May 2, 2025 09:40
@amovar18 amovar18 moved this to Under Review in PS Analysis Tool May 2, 2025
@amovar18 amovar18 added this to the v1.0 milestone May 2, 2025
@amovar18 amovar18 marked this pull request as ready for review May 2, 2025 09:40
@mohdsayed mohdsayed merged commit 6ea57d2 into develop May 2, 2025
@mohdsayed mohdsayed deleted the ref/split-content-script branch May 2, 2025 10:55
@github-project-automation github-project-automation Bot moved this from Under Review to Done in PS Analysis Tool May 2, 2025
@mohdsayed mohdsayed mentioned this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants