Skip to content

Fix: Table row highlight colors#1076

Merged
mohdsayed merged 6 commits into
developfrom
fix/table-row-highlight
May 29, 2025
Merged

Fix: Table row highlight colors#1076
mohdsayed merged 6 commits into
developfrom
fix/table-row-highlight

Conversation

@CharliePops

@CharliePops CharliePops commented May 14, 2025

Copy link
Copy Markdown
Contributor

Description

Use lighter color for selected row

Testing Instructions

  1. Pull and checkout the branch fix/table-row-highlight
  2. Build and run the extension: npm run build:all && npm run start
  3. Open Privacy Sandbox tab on DevTools
  4. Go to any table
  5. Select a row
  6. Make it lose focus by clicking outside the table

Screenshot/Screencast

Screenshot 2025-05-14 at 4 59 20 PM Screenshot 2025-05-14 at 4 58 40 PM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops self-assigned this May 14, 2025
@CharliePops CharliePops marked this pull request as ready for review May 14, 2025 16:12
@CharliePops CharliePops changed the title Fix: selected table row highlight Fix: Table row highlight colors May 15, 2025
@mohdsayed mohdsayed requested a review from mayan-000 May 19, 2025 06:29
Comment thread packages/design-system/src/components/table/components/tableBody/bodyRow.tsx Outdated

@mayan-000 mayan-000 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just one small change requested.

@CharliePops CharliePops requested a review from mayan-000 May 19, 2025 10:09
@mayan-000 mayan-000 requested a review from mohdsayed May 20, 2025 13:51
@mohdsayed mohdsayed added this to the v1.0 milestone May 29, 2025
@mohdsayed mohdsayed merged commit e551b47 into develop May 29, 2025
@mohdsayed mohdsayed deleted the fix/table-row-highlight branch May 29, 2025 05:50
@mohdsayed mohdsayed mentioned this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants