Skip to content

Feature: Prebid integration#1078

Merged
mohdsayed merged 24 commits into
developfrom
feat/prebid-integration-init
May 26, 2025
Merged

Feature: Prebid integration#1078
mohdsayed merged 24 commits into
developfrom
feat/prebid-integration-init

Conversation

@amovar18

@amovar18 amovar18 commented May 16, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR aims to integrate Prebid with PSAT.

Relevant Technical Choices

  • Since content script works in an isolated world, the content script doesn't have the ability to read global object.
  • To overcome this issue, we have added prebidInterface.tsx as a web_accessible_resource, which will access prebid global and add event listeners.
  • Then using postMessage web_accessible_resource sends the message to the content_script which reads the data and sends the message to the service_worker to store the data.
  • The architecture of the feature is presented below:
    Screenshot 2025-05-16 at 14 33 44

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
    - [ ] The QA of this PR is done by a member of the QA team (to be checked by QA). NA

@amovar18 amovar18 self-assigned this May 19, 2025
@amovar18 amovar18 added the enhancement New feature or request label May 19, 2025
@amovar18 amovar18 moved this to In Progress in PS Analysis Tool May 19, 2025
@amovar18 amovar18 added this to the v1.0 milestone May 19, 2025
@amovar18 amovar18 marked this pull request as ready for review May 19, 2025 12:11
@amovar18 amovar18 requested a review from mohdsayed May 19, 2025 12:42
Comment thread packages/extension/src/contentScript/utils/doesPrebidExist.ts Outdated
Comment thread packages/extension/src/contentScript/utils/doesPrebidExist.ts Outdated
Comment thread packages/extension/src/contentScript/utils/doesPrebidExist.ts Outdated
Comment thread packages/extension/src/contentScript/utils/mergeUnique2DArrays.ts Outdated
Comment thread packages/extension/src/manifest.json Outdated
Comment thread packages/extension/src/store/PAStore.ts
Comment thread packages/extension/src/contentScript/prebid/prebidContentScript.ts Outdated
@dmdabbs

dmdabbs commented May 21, 2025

Copy link
Copy Markdown

This PR aims to integrate Prebid with PSAT.

Interesting. Do you have a prd or other doc describing where tyou intend to head with this?

@amedina

amedina commented May 21, 2025

Copy link
Copy Markdown
Contributor

Hi @dmdabbs! Currently we are completing an experimental integration we had started a while ago. Let's set up some time to brief you on the goals we have with the integration at this point.

@amovar18 amovar18 requested a review from mohdsayed May 22, 2025 05:11
@mohdsayed mohdsayed merged commit 9a4f213 into develop May 26, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in PS Analysis Tool May 26, 2025
@mohdsayed mohdsayed deleted the feat/prebid-integration-init branch May 26, 2025 10:07
@mohdsayed mohdsayed mentioned this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants