Skip to content

Feature: PB tab UI#1083

Merged
mohdsayed merged 91 commits into
developfrom
feat/prebid-tab
May 29, 2025
Merged

Feature: PB tab UI#1083
mohdsayed merged 91 commits into
developfrom
feat/prebid-tab

Conversation

@amovar18

@amovar18 amovar18 commented May 22, 2025 •
edited by mohdsayed
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR aims to show prebid tab with prebid UI configuration which consumes prebid events and shows prebid configuration in DevTools

Relevant Technical Choices

Testing Instructions

  • Install extension.
  • Open edition.cnn.com.
  • Then open PSAT in DevTools.
  • Now scroll the page a bit till ads load.
  • In PSAT go to protected audience tab, then navigate to Prebid tab and now check the information for prebid related configuration.

Additional Information:

Screenshot/Screencast

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

amovar18 added 30 commits May 6, 2025 00:57
@amovar18
Add initial prebid config.
e712a77
@amovar18
Reset data when tab is reloaded.
f5916ad
@amovar18
Remove timeout set in prebid check function.
0677cca
@amovar18
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
48f7918 
…l into feat/prebid-integration-init
@amovar18
Store required data.
13e7942
@amovar18
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
ff3eeaa 
…l into feat/prebid-integration-init
@amovar18
Add prebid type and remove tsignore.
bd0c031
@amovar18
Update package lock and fix error in PA Store.
eeaf49f
@amovar18
Collect all relevant auction data.
a21cb9d
@amovar18
Connect contentscript serviceworker and store.
39274e1
@amovar18
Reset data on unload event.
ac9aaff
@amovar18
Fix bugs.
4027890
@amovar18
Fix small bugs and change running time.
1c3e9e1
@amovar18
Fix bug of having repeating arrays.
c5b9c52
@amovar18
Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-too…
72973cc 
…l into feat/prebid-integration-init
@amovar18
Add types and method to get config.
17c4000
@amovar18
Add prebid tab and add the UI for prebidTab.
a22471a
@amovar18
Connect table data
ec5bfe1
@amovar18
Add icons to sidebar and show icons in sidebar
a64efef
@amovar18
Add InstalledModules and PriceGranularity tabs.
e9025ce
@amovar18
Add types and show json view for BidderSettings
13bceaf
@amovar18
Show message for prebid not found on the page.
eb7bfb7
@amovar18
Add consent management tab.
8a6fb85
@amovar18
Add UserIds tab data.
23c2ba8
@amovar18
Use common component for json wrapper.
cf26581 
Add viewer for gptAuctionConfig and UserSync along with PrebidServerConfig.
@amovar18
Add prebidServer config component.
b15ab16
@amovar18
Code cleanup:
10a486c 
Add tests and comments.
@amovar18
Convert decycle to default export.
6e77cfc
@amovar18
Fix small bug.
3c3dbb1
@amovar18
Fix types and refactor function.
674546b
@amovar18 amovar18 marked this pull request as ready for review May 28, 2025 05:03
@amovar18 amovar18 moved this from In Progress to In QA in PS Analysis Tool May 28, 2025
@amovar18 amovar18 changed the title Feature: Prebid tab UI Feature: PB tab UI May 29, 2025
mohdsayed
mohdsayed approved these changes May 29, 2025
View reviewed changes

@mohdsayed mohdsayed left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohdsayed mohdsayed moved this from In QA to Done in PS Analysis Tool May 29, 2025
@mohdsayed mohdsayed merged commit 7a5380d into develop May 29, 2025
6 of 7 checks passed
@mohdsayed mohdsayed deleted the feat/prebid-tab branch May 29, 2025 13:59
@mohdsayed mohdsayed mentioned this pull request Jun 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@amovar18 amovar18

Labels

enhancement New feature or request

Projects

PS Analysis Tool
Status: Done

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@amovar18 @mohdsayed