Skip to content

Improvement: Vite warnings #1102

Merged
mohdsayed merged 8 commits into
developfrom
improvement/vite-follow-up
Jun 20, 2025
Merged

Improvement: Vite warnings #1102
mohdsayed merged 8 commits into
developfrom
improvement/vite-follow-up

Conversation

@CharliePops

@CharliePops CharliePops commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Description

  • Removes a warning during build creation about chunk size. We can explore chunking later but it's not necessary for a our kind of application
  • Remove webpack.extension.config.js, it is not used anymore
  • Created a import for 'p5' global variable

Relevant Technical Choices

Unfortunately, is not possible to remove '<script src="./p5.min.js"> in "/index.html" can't be bundled without type="module" attribute' warning

Testing Instructions

  1. Pull and checkout the branch improvement/vite-follow-up
  2. Build and run the extension: npm run start or npm run build:all
  3. Observer: There are not warning in the console(usually represented with yellow color)

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops self-assigned this Jun 18, 2025
@CharliePops CharliePops marked this pull request as ready for review June 18, 2025 13:01
@mohdsayed

Copy link
Copy Markdown
Collaborator

One workaround could be to filter out the warnings that we cannot remove, something like this. I will try this later.

"dev:ext": "run-p dev:tsc-packages vite:dev:ext 2>&1 | grep -v -f data/suppress-warnings.txt",

@mohdsayed mohdsayed added this to the v1.0 milestone Jun 20, 2025
@mohdsayed mohdsayed merged commit 8305c97 into develop Jun 20, 2025
6 checks passed
@mohdsayed mohdsayed deleted the improvement/vite-follow-up branch June 20, 2025 05:35
@mohdsayed mohdsayed mentioned this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants