Skip to content

Fix: Table column resize#1105

Merged
mohdsayed merged 19 commits into
developfrom
fix/table-column-resize
Jul 10, 2025
Merged

Fix: Table column resize#1105
mohdsayed merged 19 commits into
developfrom
fix/table-column-resize

Conversation

@CharliePops

@CharliePops CharliePops commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

Description

Allow the user to resize the column properly when the the table widht is the size of the container

Testing Instructions

  1. Pull and checkout the branch fix/table-column-resize
  2. Build and run the extension: npm run start
  3. Open Privacy Sandbox tab on DevTools
  4. Remove all extension storage: Inspect -> Application -> Extension storage
  5. Go to any place where a table data is displayed (ex: Topics EE)
  6. Observe is possible to resize columns to any size without problem (see screencast)

Note: some columns will resize too narrowed due to the content of the row or because they have explicit min width set(cookie table only currently)

Screenshot/Screencast

  • Before
before.mp4
  • After
after.mp4

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops self-assigned this Jun 19, 2025
@CharliePops CharliePops marked this pull request as ready for review June 20, 2025 10:26
@mohdsayed mohdsayed requested a review from mayan-000 June 23, 2025 05:41
@mohdsayed mohdsayed added this to the v1.0 milestone Jun 23, 2025
@mohdsayed mohdsayed modified the milestones: v1.0, Future Releases Jun 25, 2025
Comment thread packages/design-system/src/components/table/useTable/useColumnResizing/index.tsx Outdated

@mayan-000 mayan-000 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit ad2f592 into develop Jul 10, 2025
6 checks passed
@mohdsayed mohdsayed deleted the fix/table-column-resize branch July 10, 2025 13:25
@mohdsayed mohdsayed modified the milestones: Future Releases, v1.1.0 Jul 15, 2025
@mohdsayed mohdsayed mentioned this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants