Skip to content

Improvement: Vite watch#1110

Merged
mohdsayed merged 3 commits into
developfrom
improvement/vite-watch
Jul 9, 2025
Merged

Improvement: Vite watch#1110
mohdsayed merged 3 commits into
developfrom
improvement/vite-watch

Conversation

@CharliePops

@CharliePops CharliePops commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Description

  • Improves vite build time when using watch mode ~1s
  • Avoid watch script getting stucked while rebuilding by separating secondary tasks and plugins from the main devtools task
  • Unifies all extension build configuration in one file (only one npm task needed)

Testing Instructions

  1. Pull and checkout the branch improvement/vite-watch
  2. Run the extension: npm run start
  3. Open Privacy Sandbox tab on DevTools
  4. Observe the extension works correctly as in develop branch
  5. Make any change in the extension code
  6. Observer the extension is re-built and the process don't get stuck at any moment

Additional Information:

There is a rare cases when the build gets stuck immediately after starting to watch for changes, it only happened once to me and after restarting it worked fine.

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • NA This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops self-assigned this Jun 25, 2025
@CharliePops CharliePops marked this pull request as ready for review June 25, 2025 12:43
@CharliePops CharliePops requested a review from mohdsayed July 2, 2025 09:59

@amovar18 amovar18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, otherwise LGTM!

Comment thread vite.extension.config.mts Outdated
Comment thread vite.shared.config.mts
Comment thread packages/extension/package.json Outdated
@CharliePops CharliePops requested a review from amovar18 July 3, 2025 09:18

@amovar18 amovar18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed added this to the Future Releases milestone Jul 9, 2025
@mohdsayed mohdsayed merged commit 473aeb5 into develop Jul 9, 2025
5 checks passed
@mohdsayed mohdsayed deleted the improvement/vite-watch branch July 9, 2025 08:05
@mohdsayed mohdsayed modified the milestones: Future Releases, v1.1.0 Jul 15, 2025
@mohdsayed mohdsayed mentioned this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants