Skip to content

Feature: Highlight blocked script domains in MDL#1130

Merged
mohdsayed merged 37 commits into
developfrom
feat/script-blocking
Aug 22, 2025
Merged

Feature: Highlight blocked script domains in MDL#1130
mohdsayed merged 37 commits into
developfrom
feat/script-blocking

Conversation

@mohdsayed

@mohdsayed mohdsayed commented Jul 25, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR introduces support for highlighting domains in the Masked Domain List (MDL) that are subject to script blocking. It decouples script blocking logic from IP protection and adds a visual indicator when loaded scripts or iframes originate from domains listed in the MDL with specific blocking actions.

Relevant Technical Choices

  • Added a new side menu item and icon specifically for script blocking, separating it from IP Protection.
  • Created a dedicated page to list domains involved in script blocking using data from the MDL.
  • Filtered the MDL entries to only show rows where the third column indicates “Entire Domain Blocked” or “Some URLs are Blocked.”
  • Implemented logic to track domains from which active content (scripts, iframes) is loaded in the service worker.
  • Hooked into the service worker to listen for relevant network activity and send data to the provider.
  • Enabled sending of script blocking data to devtools panels
  • Matched response domains against the MDL to identify and highlight blocked sources.
  • Introduced a new provider to store and manage script-blocking-related state across the extension.
  • Updated the MDL table structure and added flags to indicate which blocked domains were actually seen during the session.

Testing Instructions

Additional Information:

Example websites blocked in MDL

Example of MDL
content.24ttl.stream

Screenshot/Screencast

image

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

mohdsayed and others added 30 commits July 22, 2025 18:41
…and for scrolling to highlighted row, add highlihgting to script blocking table
…s and update data structure to support highlighting
@mohdsayed mohdsayed self-assigned this Aug 21, 2025
@mohdsayed mohdsayed added this to the v1.2.0 milestone Aug 21, 2025
@mohdsayed mohdsayed marked this pull request as ready for review August 21, 2025 15:30
@mohdsayed mohdsayed requested review from amovar18 and mayan-000 and removed request for mayan-000 August 22, 2025 06:28

@amovar18 amovar18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, otherwise LGTM!

Comment thread packages/extension/src/view/devtools/stateProviders/scriptBlocking/context.ts Outdated
mohdsayed and others added 2 commits August 22, 2025 13:53
…criptBlocking/index.tsx

Co-authored-by: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com>
…king/context.ts

Co-authored-by: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com>
@mohdsayed mohdsayed merged commit 3889430 into develop Aug 22, 2025
6 checks passed
@mohdsayed mohdsayed deleted the feat/script-blocking branch August 22, 2025 08:39
@mohdsayed mohdsayed mentioned this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants