Skip to content

Enhancement: Keep FedCM EE state paused by default#1149

Merged
mohdsayed merged 4 commits into
developfrom
enhance/fedcm-ee-state
Sep 19, 2025
Merged

Enhancement: Keep FedCM EE state paused by default#1149
mohdsayed merged 4 commits into
developfrom
enhance/fedcm-ee-state

Conversation

@mayan-000

@mayan-000 mayan-000 commented Sep 15, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR updates logic to keep the default state of FedCM EE as paused.

Relevant Technical Choices

  • To accommodate the option to select either default paused or not, a parameter is introduced to the Main class.
  • If param paused is true, the draw loop doesn't start.
  • Adding to the above, if the param paused is true, but figureToStart has a value, the loop pauses after that figure has been rendered on the screen. This is to accommodate the workflow's persistence.

Testing Instructions

Additional Information:

Screenshot/Screencast

Screen.Recording.2025-09-15.at.5.12.30.PM.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 marked this pull request as ready for review September 15, 2025 11:43
@mayan-000 mayan-000 requested a review from mohdsayed September 15, 2025 11:43
@mohdsayed mohdsayed added this to the v1.2.0 milestone Sep 19, 2025
@mohdsayed mohdsayed merged commit 6b2266c into develop Sep 19, 2025
6 checks passed
@mohdsayed mohdsayed deleted the enhance/fedcm-ee-state branch September 19, 2025 12:25
@mohdsayed mohdsayed mentioned this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants