Skip to content

Feature: Add breadcrumbs to landing pages#832

Merged
mohdsayed merged 8 commits into
release/v0.11.0from
feat/breadcrumbs
Sep 10, 2024
Merged

Feature: Add breadcrumbs to landing pages#832
mohdsayed merged 8 commits into
release/v0.11.0from
feat/breadcrumbs

Conversation

@mayan-000

@mayan-000 mayan-000 commented Sep 6, 2024

Copy link
Copy Markdown
Collaborator

Description

This PR adds a component for rendering breadcrumbs.

Relevant Technical Choices

  • useSidebar returns a new callback extractSidebarItemKeyTitles to output an array of an object containing the title and key.
  • Array<{title: string, key: string}>

Testing Instructions

  • Open PSAT tool and navigate to Site boundaries landing page.
  • Under the title there should be breadcrumbs visible.
  • Click on any element and it should navigate to other page.
  • Try on other landing pages too.

Additional Information:

Screenshot/Screencast

Screenshot 2024-09-06 at 15 07 29

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@pavanpatil1

pavanpatil1 commented Sep 6, 2024

Copy link
Copy Markdown
Collaborator
  • The breadcrumb title appears on the main landing page, but it should be hidden there and displayed only on subpages.
Screenshot 2024-09-06 at 4 13 08 PM
  • The current page in the breadcrumb navigation should be non-clickable. Currently, the link for the current page is still clickable.
Screenshot 2024-09-06 at 4 16 43 PM
  • Could we add some space between the breadcrumb and the heading? They appear too close together. Alternatively, we could place the breadcrumb above the heading
Screenshot 2024-09-06 at 4 18 47 PM

@mayan-000 mayan-000 marked this pull request as ready for review September 10, 2024 07:21

@mohdsayed mohdsayed left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mohdsayed mohdsayed merged commit 1d90d59 into release/v0.11.0 Sep 10, 2024
@mohdsayed mohdsayed deleted the feat/breadcrumbs branch September 10, 2024 14:45
@mohdsayed mohdsayed mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants