Mapping categories under personalization and security to Functional#891
Merged
Merged
Conversation
mohdsayed
approved these changes
Mar 20, 2025
mohdsayed
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR. Looks good
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request maps the cookies under the categories of personalization and security to functional, fixing issue #889.
Relevant Technical Choices
The 27 cookies categorized as personalization and security from the cookie database were listed as uncategorized when they were listed on the cookie database. This pull request changes the script
update-cookie-db.cjsresponsible for reading the cookies from the cookie database and converting it into JSON format. The change maps the categoriessecurityandpersonalizationasFunctionalto not impact the current categorization.Testing Instructions
fix/security-personalization-categoriesnpm run cookie-db:updateto update the cookie databasenpm run build:allglobo.com__eoicookieAdditional Information:
Screenshot/Screencast
Before:

After:

Checklist
Fixes #889