Skip to content

Mapping categories under personalization and security to Functional#891

Merged
mohdsayed merged 1 commit into
developfrom
fix/security-personalization-categories
Mar 20, 2025
Merged

Mapping categories under personalization and security to Functional#891
mohdsayed merged 1 commit into
developfrom
fix/security-personalization-categories

Conversation

@fellyph

@fellyph fellyph commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

Description

This pull request maps the cookies under the categories of personalization and security to functional, fixing issue #889.

Relevant Technical Choices

The 27 cookies categorized as personalization and security from the cookie database were listed as uncategorized when they were listed on the cookie database. This pull request changes the script update-cookie-db.cjs responsible for reading the cookies from the cookie database and converting it into JSON format. The change maps the categories security and personalization as Functional to not impact the current categorization.

Testing Instructions

  1. Pull the branch fix/security-personalization-categories
  2. Run the command npm run cookie-db:update to update the cookie database
  3. Build the project npm run build:all
  4. Navigate to globo.com
  5. Open the cookie table at the privacy sandbox tab on DevTools
  6. Filter the cookies for third-party and search the __eoi cookie

Additional Information:

Screenshot/Screencast

Before:
Screenshot 2024-12-11 at 09 39 29

After:
Screenshot 2024-12-11 at 15 49 35


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #889

@amovar18 amovar18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good

@mohdsayed mohdsayed added this to the v0.13.0 milestone Mar 20, 2025
@mohdsayed mohdsayed merged commit 1820950 into develop Mar 20, 2025
@mohdsayed mohdsayed deleted the fix/security-personalization-categories branch March 20, 2025 07:33
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants