Skip to content

PA EE code refactoring and small fixes#893

Merged
mohdsayed merged 10 commits into
developfrom
pa-ee-code-ref
Dec 16, 2024
Merged

PA EE code refactoring and small fixes#893
mohdsayed merged 10 commits into
developfrom
pa-ee-code-ref

Conversation

@mohdsayed

@mohdsayed mohdsayed commented Dec 13, 2024

Copy link
Copy Markdown
Collaborator

Description

  • Change background to white and fix circle override
  • Change circle color to visited green after visit
  • Show info info to only boxes with info
  • Fix arrows not taking colors.
  • Use smooth() for main canvas
  • Create separate functions for setting up ad auction, ssp flow, branches and ad unit code

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mohdsayed mohdsayed added this to the v1.0 milestone Dec 13, 2024
@mohdsayed mohdsayed marked this pull request as ready for review December 13, 2024 08:24

@amovar18 amovar18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 6fc2ada into develop Dec 16, 2024
@mohdsayed mohdsayed deleted the pa-ee-code-ref branch December 16, 2024 07:45
@mohdsayed mohdsayed modified the milestones: v1.0, v0.13.0 Mar 21, 2025
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants