Skip to content

Fix: Interactive mode switching#896

Merged
mohdsayed merged 11 commits into
developfrom
fix/queueing-problem
Dec 16, 2024
Merged

Fix: Interactive mode switching#896
mohdsayed merged 11 commits into
developfrom
fix/queueing-problem

Conversation

@amovar18

Copy link
Copy Markdown
Collaborator

Description

This PR fixes the problem of interactive mode and non-interactive mode switching in Protected Audience EE.

Relevant Technical Choices

  • Remove custom implementation of Promise Queue and add Queue package to manage queueing problem.

Testing Instructions

  • Clone this branch.
  • In the terminal run npm i && npm run dev:ee:pa.
  • Now in the canvas, try switching between interactive and non-interactive mode.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended.
    - [ ] The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@amovar18 amovar18 marked this pull request as ready for review December 16, 2024 05:43
@amovar18 amovar18 self-assigned this Dec 16, 2024
@amovar18 amovar18 changed the title Fix: Interactive mode switching, Fix: Interactive mode switching Dec 16, 2024
@mohdsayed mohdsayed added this to the v1.0 milestone Dec 16, 2024
@mohdsayed mohdsayed merged commit c94095c into develop Dec 16, 2024
@mohdsayed mohdsayed deleted the fix/queueing-problem branch December 16, 2024 11:14
@mohdsayed mohdsayed modified the milestones: v1.0, v0.13.0 Mar 21, 2025
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants