Skip to content

Feature: Synchnorise data population in table with respect to the EE PA#924

Merged
mohdsayed merged 15 commits into
developfrom
feat/sync-data-flow
Jan 29, 2025
Merged

Feature: Synchnorise data population in table with respect to the EE PA#924
mohdsayed merged 15 commits into
developfrom
feat/sync-data-flow

Conversation

@amovar18

@amovar18 amovar18 commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR populates the data in the flow according to the EE PA.

Relevant Technical Choices

Testing Instructions

  • Clone this branch
  • In the terminal run npm i && npm run build:ext
  • Open then browser.
  • Go to example.com and open the DevTools and navigation to PSAT.
  • Go to protected audience and then see the flow.
  • In the table you should see data being synchronous with the EE being shown above.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@amovar18 amovar18 self-assigned this Jan 27, 2025
@amovar18 amovar18 added this to the v0.13.0 milestone Jan 27, 2025
@mohdsayed mohdsayed marked this pull request as ready for review January 29, 2025 04:45
Comment thread packages/explorable-explanations/src/protectedAudience/modules/auctions/index.js Outdated
Comment thread packages/explorable-explanations/src/protectedAudience/modules/auctions/index.js Outdated
) : (
<div className="h-full p-8 flex items-center justify-center">
<p className="text-center text-lg">
Auction Events yet to be recorded.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Auction Events yet to be recorded.
Auction events have yet to be recorded.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in latest commits.

@mohdsayed mohdsayed left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments to address.

@amovar18 amovar18 requested a review from mohdsayed January 29, 2025 07:54
@mohdsayed mohdsayed merged commit 8e2f00e into develop Jan 29, 2025
@mohdsayed mohdsayed deleted the feat/sync-data-flow branch January 29, 2025 08:56
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants