Skip to content

Enhancement: Update IG highlighting logic#933

Merged
mohdsayed merged 2 commits into
developfrom
ig-highlighting
Jan 31, 2025
Merged

Enhancement: Update IG highlighting logic#933
mohdsayed merged 2 commits into
developfrom
ig-highlighting

Conversation

@mayan-000

@mayan-000 mayan-000 commented Jan 30, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR adds code that updates the highlighting and unhighlighting timing.

  • Keep the latest selected bubble's related row in the IG table highlighted.
  • Add a stroke to the selected bubble.
  • Clear highlighting of row once bubble minimized.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Screen.Recording.2025-01-30.at.15.03.22.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mayan-000 mayan-000 marked this pull request as ready for review January 30, 2025 09:44
@mayan-000 mayan-000 requested a review from mohdsayed January 30, 2025 09:44
@mayan-000 mayan-000 self-assigned this Jan 30, 2025
@mayan-000 mayan-000 added this to the v1.0 milestone Jan 30, 2025
@mayan-000 mayan-000 requested a review from amovar18 January 30, 2025 09:44
@mohdsayed mohdsayed merged commit 6c29cc0 into develop Jan 31, 2025
@mohdsayed mohdsayed deleted the ig-highlighting branch January 31, 2025 05:02
@mohdsayed mohdsayed modified the milestones: v1.0, v0.13.0 Mar 21, 2025
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants