Skip to content

Feature: Create a new 'Worklet Breakpoints' tab#935

Merged
mohdsayed merged 24 commits into
developfrom
add/info-to-breakpoints
Jan 31, 2025
Merged

Feature: Create a new 'Worklet Breakpoints' tab#935
mohdsayed merged 24 commits into
developfrom
add/info-to-breakpoints

Conversation

@mohdsayed

@mohdsayed mohdsayed commented Jan 30, 2025

Copy link
Copy Markdown
Collaborator

Description

Create a new 'Worklet Breakpoints' tab and move breakpoints from the Auction tab to this new tab. Add information about these breakpoints and a screenshot.

Relevant Technical Choices

  • Refactor TableTray component to handle toggling the tray and move it to the design-system package.
  • Add a new tab tabItems for this new tab.
  • Move Breakpoint component to the new workletBreakpoint directory.
  • Extend webpack config to support images and declare it in @types/index.d.ts

Testing Instructions

Additional Information:

Screenshot/Screencast

image


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #786

@mohdsayed mohdsayed self-assigned this Jan 30, 2025
@mohdsayed mohdsayed added this to the v0.13.0 milestone Jan 30, 2025
@mohdsayed mohdsayed changed the title Enhancement: Add info to "Ad Worklet Breakpoints" in auction Feature: Create a new 'Worklet Breakpoints' tab Jan 31, 2025
@mohdsayed mohdsayed added the feature Feature/capability of the tool label Jan 31, 2025
@mohdsayed mohdsayed marked this pull request as ready for review January 31, 2025 04:33
@mohdsayed mohdsayed requested a review from amovar18 January 31, 2025 04:33

@amovar18 amovar18 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 39cb8e4 into develop Jan 31, 2025
@mohdsayed mohdsayed deleted the add/info-to-breakpoints branch January 31, 2025 08:10
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Feature/capability of the tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants