Skip to content

Feature: Preserve protected audience explorable explanation settings#938

Merged
mohdsayed merged 22 commits into
developfrom
feat/preserve-ee-settings
Feb 5, 2025
Merged

Feature: Preserve protected audience explorable explanation settings#938
mohdsayed merged 22 commits into
developfrom
feat/preserve-ee-settings

Conversation

@mohdsayed

@mohdsayed mohdsayed commented Feb 3, 2025

Copy link
Copy Markdown
Collaborator

Description

Relevant Technical Choices

Testing Instructions

  • Clone this branch.
  • In the terminal, run npm i && npm run build:ext
  • Now go to example.com.
  • Now open DevTools and navigate to PSAT extension.
  • Navigate to explorable explanation in PSAT.
  • In the EE check or uncheck a setting, now right click and then in the context menu reload frame.
  • You should see that the settings that were previously applied have been preserved.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    - [ ] This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mohdsayed mohdsayed added this to the v0.13.0 milestone Feb 3, 2025
@mohdsayed mohdsayed self-assigned this Feb 3, 2025
@amovar18 amovar18 marked this pull request as ready for review February 5, 2025 10:20
@amovar18 amovar18 requested a review from mayan-000 February 5, 2025 10:20
@mohdsayed mohdsayed merged commit 165d0a0 into develop Feb 5, 2025
@mohdsayed mohdsayed deleted the feat/preserve-ee-settings branch February 5, 2025 13:12
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants