Skip to content

Fix: Misc QA issues#954

Merged
mohdsayed merged 12 commits into
developfrom
fix/develop-qa
Feb 17, 2025
Merged

Fix: Misc QA issues#954
mohdsayed merged 12 commits into
developfrom
fix/develop-qa

Conversation

@amovar18

@amovar18 amovar18 commented Feb 14, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR aims to fix the following issues listed in testing instructions.

Relevant Technical Choices

Testing Instructions

  • Clone this branch.
  • In terminal run npm i && npm run build:ext.
  • Open browser then open example.com now navigate to PSAT after opening DevTools.
  • Test the things listed in the relevant technical choices.

Issue fixes:

  • The flow collapses after it finishes in interactive mode for the first time.
  • Keep auto-scroll off by default.
  • Latest bid is incorrect in auction.
  • Cookies inspect icon highlights (regression)
  • Data inconsistency in multi seller auction table
  • When in interactive mode, bids data is not populated in table
  • When using multi seller auctions, footer table’s sidebar for ad-unit remains gray after data is populated.
  • When using multi seller auctions, footer table’s sidebar for ad-unit closes even after opening
  • In web stories section, the title should be in upper case.
  • In web stories section, only the author ring should be available, and it should not show publisher name.
  • When in interactive mode with Auto Expand disabled, the Auctions data didn't populate for selected flows (ad units)

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
    ~~ - [ ] This code is covered by unit tests to verify that it works as intended. ~~ NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 changed the title Fix/develop qa Fix: develop QA issues Feb 14, 2025
@mohdsayed mohdsayed changed the title Fix: develop QA issues Fix: Misc QA issues Feb 17, 2025
@mohdsayed mohdsayed added this to the v0.13.0 milestone Feb 17, 2025
@mohdsayed mohdsayed added the bug Something isn't working label Feb 17, 2025
@amovar18 amovar18 self-assigned this Feb 17, 2025
@amovar18 amovar18 marked this pull request as ready for review February 17, 2025 13:36
@mohdsayed mohdsayed merged commit 37f4318 into develop Feb 17, 2025
@mohdsayed mohdsayed deleted the fix/develop-qa branch February 17, 2025 15:53
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants