Skip to content

Fix: Add missing API pages#957

Merged
mohdsayed merged 5 commits into
developfrom
fix/add-missing-api-pages
Feb 18, 2025
Merged

Fix: Add missing API pages#957
mohdsayed merged 5 commits into
developfrom
fix/add-missing-api-pages

Conversation

@CharliePops

@CharliePops CharliePops commented Feb 17, 2025

Copy link
Copy Markdown
Contributor

Description

Add missing pages for the Private Sandbox APIs

Testing Instructions

  1. Pull the branch fix/add-missing-api-pages
  2. Build and run project the project: npm run build:all && npm run dev:ext
  3. Open privacy sandbox tab on DevTools
  4. Open the 'Site Boundaries' menu item on the left
  5. Observe: there is child with a page for each API (in the right order)
  6. Observe: The icons change to white color when selected
  7. Open the 'Tracking Protection' menu item on the left
  8. Observe: there is child with a page for each API (in the right order)
  9. Observe: The icons change to white color when selected

Additional Information:

'Site Boundaries' and 'Tracking Protection' are the only sections missing pages

Screenshot/Screencast

Screenshot 2025-02-18 at 10 19 42 AM Screenshot 2025-02-18 at 10 19 26 AM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@mohdsayed mohdsayed added this to the v0.13.0 milestone Feb 18, 2025
@CharliePops CharliePops marked this pull request as ready for review February 18, 2025 09:31

@mohdsayed mohdsayed left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@mohdsayed mohdsayed merged commit dbfaf26 into develop Feb 18, 2025
@mohdsayed mohdsayed deleted the fix/add-missing-api-pages branch February 18, 2025 12:13
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants