Skip to content

Enhancement: Sidebar and landing page icons#985

Merged
mohdsayed merged 3 commits into
developfrom
enhancement/menu-landing-page-icons
Mar 5, 2025
Merged

Enhancement: Sidebar and landing page icons#985
mohdsayed merged 3 commits into
developfrom
enhancement/menu-landing-page-icons

Conversation

@CharliePops

@CharliePops CharliePops commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Description

Sidebar and landing page(cards) icons

Addressing:

  • Make all icons in the dashboard and learing landing page brigther in dark mode
  • Fixe the settings and learning page icon color in sidbare when not selected
  • Fixe the icons colors when the sidebar is collapsed
  • Fixe the icons in collapsed sidebar in light and dark mode
  • Use CSS to style color instead have 2 svg's where possible

Testing Instructions

  1. Pull and checkout the branch enhancement/menu-landing-page-icons
  2. Build and run the extension: npm run build:all && npm run dev:ext
  3. Turn on dark theme in the browser
  4. Open Privacy Sandbox tab on DevTools
  5. Observe: the sidebar icons have consistent color scheme, wheter they are selected or not
  6. Collapse the sidebar
  7. Observe: the sidebar icons have consistent color scheme, wheter they are selected or not
  8. Turn on light theme in the browser
  9. Repeat steps 6-8.

Screenshot/Screencast

icons.mp4

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops changed the title Enhancement: Menu and landing page icons Enhancement: Sidbebar and landing page icons Mar 4, 2025
@CharliePops CharliePops self-assigned this Mar 4, 2025
@CharliePops CharliePops marked this pull request as ready for review March 4, 2025 15:09
@maitreyie-chavan maitreyie-chavan changed the title Enhancement: Sidbebar and landing page icons Enhancement: Sidebar and landing page icons Mar 5, 2025
@CharliePops CharliePops requested a review from mohdsayed March 5, 2025 10:16
@mohdsayed mohdsayed added this to the v0.13.0 milestone Mar 5, 2025
@mohdsayed mohdsayed merged commit cd9f9a0 into develop Mar 5, 2025
@mohdsayed mohdsayed deleted the enhancement/menu-landing-page-icons branch March 5, 2025 11:28
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants