Skip to content

Fix: EE box info icon#990

Merged
mohdsayed merged 1 commit into
developfrom
fix/ee-box-info-icon
Mar 6, 2025
Merged

Fix: EE box info icon#990
mohdsayed merged 1 commit into
developfrom
fix/ee-box-info-icon

Conversation

@CharliePops

@CharliePops CharliePops commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

Description

Fixing logic of the box info icon

Testing Instructions

  1. Pull and checkout the branch fix/ee-box-info-icon
  2. Build and run the extension: npm run build:all && npm run dev:ext
  3. Open Privacy Sandbox tab on DevTools
  4. Go to Private Advertising
  5. Go to Explorable Explanations tab
  6. Observe: the Boxes in the diagram show an info icon
  7. Click the icon
  8. Observe: the bottom panel is updated with the information

Screenshot/Screencast

Screenshot 2025-03-06 at 10 07 39 AM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • [NA] This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@CharliePops CharliePops self-assigned this Mar 6, 2025
}

if (info && typeof info === 'string') {
if (info) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we missed this in #983 review.

@mohdsayed mohdsayed added this to the v0.13.0 milestone Mar 6, 2025
@mohdsayed mohdsayed merged commit 1dfaafa into develop Mar 6, 2025
@mohdsayed mohdsayed deleted the fix/ee-box-info-icon branch March 6, 2025 10:39
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants