Skip to content

Fix: QA develop#994

Merged
mohdsayed merged 12 commits into
developfrom
fix/qa-develop
Mar 12, 2025
Merged

Fix: QA develop#994
mohdsayed merged 12 commits into
developfrom
fix/qa-develop

Conversation

@amovar18

@amovar18 amovar18 commented Mar 11, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR aims to fix develop issues.

Relevant Technical Choices

  • Scrolling of ad units is being done now using their top and left coordinates.
  • Protocol matching is now changed, since protocol used to be https and https:.

Testing Instructions

  • Clone this branch.
  • In the terminal run npm run build:ext
  • Open a fresh profile and then go to https://psat-pat-demos-shop.dev/items/1f45f?auctionType=multi
  • then in another tab open https://psat-pat-demos-news.dev?auctionType=multi.
  • Now Go to ad Units section in the PA tab of DevTools.
  • Click on ad unit to enable frame overlay, the ad should scroll into view.
  • Now go to RWS JSON generator, ensure that domain is validated.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@amovar18 amovar18 added the bug Something isn't working label Mar 11, 2025
@amovar18 amovar18 moved this to In Progress in PS Analysis Tool Mar 11, 2025
@amovar18 amovar18 added this to the v0.13.0 milestone Mar 11, 2025
@amovar18 amovar18 marked this pull request as ready for review March 12, 2025 13:24
@mohdsayed mohdsayed merged commit 9dff9ad into develop Mar 12, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in PS Analysis Tool Mar 12, 2025
@mohdsayed mohdsayed deleted the fix/qa-develop branch March 12, 2025 13:49
@mohdsayed mohdsayed mentioned this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants