Skip to content
This repository was archived by the owner on May 16, 2025. It is now read-only.

Commit bb327ee

Browse files
authored
Adding support for the .NET Core 2.0 runtime. (#785)
* Adding support for the .NET Core 2.0 runtime. * Fixing typo.
1 parent 99ec8f9 commit bb327ee

File tree

5 files changed

+15
-3
lines changed

5 files changed

+15
-3
lines changed

GoogleCloudExtension/GoogleCloudExtension.Deployment/KnownProjectTypes.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,10 @@ public enum KnownProjectTypes
3838
/// An ASP.NET Core 1.1 app
3939
/// </summary>
4040
NetCoreWebApplication1_1,
41+
42+
/// <summary>
43+
/// An ASP.NET Core 2.0 app
44+
/// </summary>
45+
NetCoreWebApplication2_0,
4146
}
4247
}

GoogleCloudExtension/GoogleCloudExtension.Deployment/NetCoreAppUtils.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ internal static class NetCoreAppUtils
3333
private static readonly Dictionary<KnownProjectTypes, string> s_knownRuntimeImages = new Dictionary<KnownProjectTypes, string>
3434
{
3535
[ KnownProjectTypes.NetCoreWebApplication1_0 ] = "gcr.io/google-appengine/aspnetcore:1.0",
36-
[ KnownProjectTypes.NetCoreWebApplication1_1 ] = "gcr.io/google-appengine/aspnetcore:1.1"
36+
[ KnownProjectTypes.NetCoreWebApplication1_1 ] = "gcr.io/google-appengine/aspnetcore:1.1",
37+
[ KnownProjectTypes.NetCoreWebApplication2_0 ] = "gcr.io/google-appengine/aspnetcore:2.0"
3738
};
3839

3940
/// <summary>

GoogleCloudExtension/GoogleCloudExtension/Projects/DotNetCore/CsprojProject.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ public CsprojProject(Project project, string targetFramework)
5353
ProjectType = KnownProjectTypes.NetCoreWebApplication1_1;
5454
break;
5555

56+
case "netcoreapp2.0":
57+
ProjectType = KnownProjectTypes.NetCoreWebApplication2_0;
58+
break;
59+
5660
default:
5761
GcpOutputWindow.OutputDebugLine($"Unsopported target framework {targetFramework}");
5862
ProjectType = KnownProjectTypes.None;

GoogleCloudExtension/GoogleCloudExtension/PublishDialog/PublishDialogWindow.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ public static bool CanPublish(IParsedProject project)
5555
var projectType = project.ProjectType;
5656
return projectType == KnownProjectTypes.WebApplication ||
5757
projectType == KnownProjectTypes.NetCoreWebApplication1_0 ||
58-
projectType == KnownProjectTypes.NetCoreWebApplication1_1;
58+
projectType == KnownProjectTypes.NetCoreWebApplication1_1 ||
59+
projectType == KnownProjectTypes.NetCoreWebApplication2_0;
5960
}
6061
}
6162
}

GoogleCloudExtension/GoogleCloudExtension/PublishDialogSteps/ChoiceStep/ChoiceStepViewModel.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,7 @@ public static IPublishDialogStep CreateStep()
136136

137137
private static bool IsSupportedNetCoreProject(IParsedProject project)
138138
=> project.ProjectType == KnownProjectTypes.NetCoreWebApplication1_0 ||
139-
project.ProjectType == KnownProjectTypes.NetCoreWebApplication1_1;
139+
project.ProjectType == KnownProjectTypes.NetCoreWebApplication1_1 ||
140+
project.ProjectType == KnownProjectTypes.NetCoreWebApplication2_0;
140141
}
141142
}

0 commit comments

Comments
 (0)