Updating the nuget packages to the latest bits. #806
Conversation
ILMTitan
left a comment
There was a problem hiding this comment.
I'm slightly confused by the <bindingRedirect> elements in the app.config files, but otherwise looks good to me.
| </dependentAssembly> | ||
| </assemblyBinding> | ||
| </runtime> | ||
| </configuration> No newline at end of file |
There was a problem hiding this comment.
I'm not sure why this binding redirect was created. I don't see a package reference that depends on any other version besides 1.29.1. Did you miss updating a package?
|
I have updated to the release today of the NuGet packages. All instances of the |
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
=========================================
- Coverage 11.64% 3.18% -8.47%
=========================================
Files 503 503
Lines 12293 12292 -1
=========================================
- Hits 1432 391 -1041
- Misses 10861 11901 +1040
Continue to review full report at Codecov.
|
|
I rolled back the changes I made today, specially the update to Interestingly the build in AppVeyor didn't actually fail, the only error was the drop in the code coverage due to the tests not running. This seems to imply that the tests failure are not reflected in the final build. I have opened #808 to track this issue. |
Updating the Google and other essential packages to the latest bits.