Don't rely on AWT in rememberCursorPositionProvider#432
Merged
Conversation
| ) | ||
| } | ||
| val pointerPositions = LocalPointerPositions.current | ||
| val cursorPoint = remember { pointerPositions.entries.first().value.round() } |
There was a problem hiding this comment.
In the future when Igor Demin (@igordmn) will merge his changes about multi-touch support, we can filter by mouse here.
27a5bac to
22559d6
Compare
Igor Demin (igordmn)
approved these changes
Mar 20, 2023
…ts instead To implement it current pointer positions should be provided. Add test for rememberCursorPositionProvider. Co-authored-by: Igor Demin <igordmn@users.noreply.github.com>
3a75022 to
3fb1d24
Compare
Author
|
Rebased on Sasha's changes (squashed my commits into one), also removed some redundant waits. Some waits are still needed |
Alexander Maryanovsky (m-sasha)
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
LocalPointerPositionsthat provides a way to get the current position of pointers. It is used inrememberCursorPositionProviderrememberCursorPositionProviderdoesn't rely on AWT anymoreTesting
Test: newly introduced
TooltipAreaTestandDesktopCursorPositionTestIssues Fixed
Fixes: JetBrains/compose-multiplatform#2821