Skip to content

Fixing three mcore links#14839

Merged
pablo-garay merged 2 commits into
mainfrom
fix/bad-mcore-links
Sep 30, 2025
Merged

Fixing three mcore links#14839
pablo-garay merged 2 commits into
mainfrom
fix/bad-mcore-links

Conversation

@aschilling-nv

@aschilling-nv aschilling-nv commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

Correct the case on three Megatron-Core links to fix the linkchecker issue.

Collection: [Note which collection this PR will affect]

Changelog

  • Correct three URLs in NeMo/docs/source/features/parallelisms.rst
  • Added three URLs to the false positive list; they are slow to load, but do load
  • Added NeMo Blog URL to false positive list for now, still needs to be looked at by @chtruong814 .
  • Corrected two URLs that were redirecting in nemo/NeMo/docs/source/nlp/nlp_all.bib

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Matches other Megatron-Core links in NeMo/docs/source/checkpoints/dist_ckpt.rst and NeMo/examples/llm/resiliency/resiliency-in-pretraining-demo.ipynb

@aschilling-nv aschilling-nv self-assigned this Sep 29, 2025
@github-actions github-actions Bot added the NLP label Sep 29, 2025
Signed-off-by: Andrew Schilling <aschilling@nvidia.com>
Signed-off-by: Andrew Schilling <aschilling@nvidia.com>
@pablo-garay pablo-garay merged commit da1b015 into main Sep 30, 2025
33 checks passed
@pablo-garay pablo-garay deleted the fix/bad-mcore-links branch September 30, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants