Skip to content

fix: Use RestrictedUnpickler in nemo.lightning.io.mixin#15597

Merged
chtruong814 merged 8 commits into
r2.7.0from
chtruong/fix-io-load
Apr 13, 2026
Merged

fix: Use RestrictedUnpickler in nemo.lightning.io.mixin#15597
chtruong814 merged 8 commits into
r2.7.0from
chtruong/fix-io-load

Conversation

@chtruong814

@chtruong814 chtruong814 commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do ?

fix: Use RestrictedUnpickler in nemo.lightning.io.mixin

This module is actually already deleted on main branch. But we aren't planning a release near-term, so let's clean it up in a patch. This uses RestrictedUnpickler to only allow certain objects to be loaded from known paths.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 force-pushed the chtruong/fix-io-load branch from 82fb77d to d7e4110 Compare April 11, 2026 21:41
@chtruong814 chtruong814 changed the title fix: Remove pickle usage in nemo.lightning.io.mixin fix: Use RestrictedUnpickler in nemo.lightning.io.mixin Apr 11, 2026
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: chtruong814 <chtruong814@users.noreply.github.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
Signed-off-by: Charlie Truong <chtruong@nvidia.com>
This reverts commit 1a300a5.

Signed-off-by: Charlie Truong <chtruong@nvidia.com>
@chtruong814 chtruong814 merged commit 76810d5 into r2.7.0 Apr 13, 2026
48 checks passed
@chtruong814 chtruong814 deleted the chtruong/fix-io-load branch April 13, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants