[rb] implement downloading grid with Selenium Manager#12299
Closed
titusfortner wants to merge 1 commit intoSeleniumHQ:trunkfrom
Closed
[rb] implement downloading grid with Selenium Manager#12299titusfortner wants to merge 1 commit intoSeleniumHQ:trunkfrom
titusfortner wants to merge 1 commit intoSeleniumHQ:trunkfrom
Conversation
p0deje
approved these changes
Jul 3, 2023
Member
p0deje
left a comment
There was a problem hiding this comment.
selenium/server.rb always seemed to much for me - I like SM approach.
Member
Author
|
I think ruby is the only one that implemented it in the first place, though. It's a great feature, and would be nice to have in all the bindings. But yes, this is exactly the kind of overhead and duplication that Selenium manager is great at removing. (thanks again @bonigarcia) |
8acd0ef to
b630132
Compare
Member
|
I believe we still want to implement this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
I'm moving this to draft for us to discuss whether we want to implement this in other bindings and synchronize the versions.
Also, play-by-play is here - https://www.youtube.com/watch?v=0rL6Dtoo8As
Description
Motivation and Context
Types of changes