[py] Exclude devtools directory from type checking#15695
Merged
cgoldberg merged 2 commits intoSeleniumHQ:trunkfrom May 3, 2025
Merged
[py] Exclude devtools directory from type checking#15695cgoldberg merged 2 commits intoSeleniumHQ:trunkfrom
cgoldberg merged 2 commits intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
This was referenced Sep 12, 2025
This was referenced Sep 19, 2025
This was referenced Oct 1, 2025
This was referenced Dec 21, 2025
This was referenced Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
💥 What does this PR do?
This PR changes the Mypy configuration (for type checking) to exclude files in the
py/selenium/webdriver/common/devtoolsdirectory.This is a prelude to fixing type checking across the Python bindings. Even with this change, we currently have 120 errors in 30 files when running Mypy!!
🔧 Implementation Notes
We don't really care about type checking in the generated devtools files (our linters skip them also)
Note: we don't fail CI for type checking errors
PR Type
Enhancement
Description
Excludes
devtoolsdirectory from MyPy type checkingUpdates MyPy configuration in
pyproject.tomlPrepares for broader type checking improvements
Changes walkthrough 📝
pyproject.toml
Exclude devtools directory from MyPy type checkingpy/pyproject.toml
excludedirective forselenium/webdriver/common/devtools