[py] Refactored server.py in a more pythonic approach.#15840
[py] Refactored server.py in a more pythonic approach.#15840cgoldberg merged 5 commits intoSeleniumHQ:trunkfrom
server.py in a more pythonic approach.#15840Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
@cgoldberg can you please trigger CI for this one |
|
@shbenzer @cgoldberg can you please review this PR please.. Thanks! |
cgoldberg
left a comment
There was a problem hiding this comment.
The attributes should be private
User description
🔗 Related Issues
💥 What does this PR do?
Refactored
server.pyin a more pythonic approach by implementingpropertydescriptors.🔧 Implementation Notes
Implemented standard
gettersandsettersto set various server parameters.💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Refactored
server.pyto use Python property descriptorsReplaced validation methods with property setters
Improved attribute validation and encapsulation
Enhanced code readability and maintainability
Changes walkthrough 📝
server.py
Refactor server attributes using properties and setterspy/selenium/webdriver/remote/server.py
path,port,version,log_level, andenvstatus_urlto be a property