[dotnet] Implement third-party Permissions module#16414
[dotnet] Implement third-party Permissions module#16414nvborisenko merged 25 commits intoSeleniumHQ:trunkfrom
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
nvborisenko
left a comment
There was a problem hiding this comment.
No value,. In any case thank you.
dotnet/src/webdriver/BiDi/Extensions/Permissions/PermissionDescriptor.cs
Outdated
Show resolved
Hide resolved
|
I didn't verify whether models follow patterns. Since we are OK with the approach, please give me a time to focus on DTO. |
|
We are on the finish line. @RenderMichael will you be able to pick up it? |
nvborisenko
left a comment
There was a problem hiding this comment.
It was amazing collaboration, thanks @RenderMichael and @YevgeniyShunevych!
User description
🔗 Related Issues
Fixes #15329
New API surface:
PR Type
Enhancement
Description
Enable external BiDi module creation and extension
Refactor module architecture with InternalModule base class
Expose Broker and JsonOptions for external access
Simplify module creation with public static method
Diagram Walkthrough
File Walkthrough
13 files
Expose internal properties and refactor module creationAdd new base class for internal modulesRefactor to support external module creationChange inheritance to InternalModuleChange inheritance to InternalModuleChange inheritance to InternalModuleChange inheritance to InternalModuleChange inheritance to InternalModuleChange inheritance to InternalModuleChange inheritance to InternalModuleChange inheritance to InternalModuleChange inheritance to InternalModuleChange inheritance to InternalModule