Skip to content

[Java] Fix typo in invisibilityOf method documentation#16456

Merged
cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom
ethbra:patch-1
Oct 17, 2025
Merged

[Java] Fix typo in invisibilityOf method documentation#16456
cgoldberg merged 1 commit intoSeleniumHQ:trunkfrom
ethbra:patch-1

Conversation

@ethbra
Copy link
Contributor

@ethbra ethbra commented Oct 17, 2025 •
edited by cgoldberg
Loading

User description

🔗 Related Issues

Fixes #16455

💥 What does this PR do?

Fixes a grammatical error in Javadocs

💡 Additional Considerations

This doesn't affect any runnable code, so no other considerations are necessary

🔄 Types of changes

  • Cleanup (formatting, renaming)

PR Type

Documentation

Description

  • Fixes grammatical error in invisibilityOf method Javadoc

  • Changes "elements is" to "element is" for accuracy

Diagram Walkthrough

flowchart LR
  A["invisibilityOf method<br/>Javadoc"] -- "Fix typo:<br/>elements → element" --> B["Corrected<br/>documentation"]
Loading

File Walkthrough
Relevant files
Documentation
ExpectedConditions.java
Fix grammar in invisibilityOf Javadoc comment                       

java/src/org/openqa/selenium/support/ui/ExpectedConditions.java

  • Corrects grammatical error in invisibilityOf method Javadoc
  • Changes "@return Boolean true when elements is not visible anymore" to
    "@return Boolean true when element is not visible anymore"
  • Improves documentation accuracy for singular WebElement parameter
 +1/-1     

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@selenium-ci selenium-ci added C-java Java Bindings B-support Issue or PR related to support classes labels Oct 17, 2025
@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Oct 17, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
⚪
🎫 No ticket provided 
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
⚪
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
⚪
No custom compliance provided

Follow the guide to enable custom compliance check.
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@selenium-ci
Copy link
Member

selenium-ci commented Oct 17, 2025

Thank you, @ethbra for this code suggestion.

The support packages contain example code that many users find helpful, but they do not necessarily represent
the best practices for using Selenium, and the Selenium team is not currently merging changes to them.

After reviewing the change, unless it is a critical fix or a feature that is needed for Selenium
to work, we will likely close the PR.

We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks.
If you have any questions, please contact us

@qodo-code-review
Copy link
Contributor

qodo-code-review bot commented Oct 17, 2025

PR Code Suggestions ✨

No code suggestions found for the PR.

@cgoldberg cgoldberg changed the title Fix typo in invisibilityOf method documentation [Java] Fix typo in invisibilityOf method documentation Oct 17, 2025
@cgoldberg cgoldberg merged commit 11998a0 into SeleniumHQ:trunk Oct 17, 2025
5 checks passed
@ethbra ethbra deleted the patch-1 branch October 17, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgoldberg cgoldberg cgoldberg approved these changes

Assignees

No one assigned

Labels

B-support Issue or PR related to support classes C-java Java Bindings Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Typo in invisibilityOf method documentation

4 participants

@ethbra @CLAassistant @selenium-ci @cgoldberg