You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The ./go rb:local_dev command is builds everything so that all assets/code that needs to be generated in the build process is created so that any tests that need to be run can be run through RubyMine instead of just bazel for better debugging options.
I have my RubyMine set to use the ruby binary stored in the bazel-selenium working directory.
For local Ruby development, if you want to run on RBE, you have to switch to jruby, and every time you change the ruby versions, RubyMine gets unhappy. Running ./go rb:local_dev should fix this, but for some reason it builds the ruby binary, but does not stage it in the bazel-selenium / working directory. Adding a command that requires using the ruby binary forces it to be staged.
PR Type
Enhancement
Description
Adds informative message during Ruby binary installation
Executes additional Bazel command to stage Ruby binary
Ensures Ruby binary is properly placed in working directory
Diagram Walkthrough
flowchart LR
A["local_dev task"] --> B["Print status message"]
B --> C["Build bundle"]
C --> D["Build Ruby"]
D --> E["Build grid"]
E --> F["Execute rubocop with dry-run"]
F --> G["Ruby binary staged in working directory"]
Loading
File Walkthrough
Relevant files
Enhancement
Rakefile
Add Ruby binary staging to local_dev task
Rakefile
Added user-facing message indicating Ruby installation is in progress
Added Bazel command execution with --dry-run flag for rubocop to force staging of Ruby binary
Included explanatory comment about the purpose of the additional command
Remove the invalid --test_arg and --dry-run flags from the Bazel.execute call. The --test_arg flag is only valid for bazel test and will cause the bazel build command to fail.
# A command like this is required to move ruby binary into working directory
-Bazel.execute('build', %w[--test_arg --dry-run], '@bundle//bin:rubocop')+Bazel.execute('build', [], '@bundle//bin:rubocop')
Apply / Chat
Suggestion importance[1-10]: 9
__
Why: The suggestion correctly identifies that the --test_arg flag is invalid for bazel build, which would cause the local_dev task to fail, thus fixing a bug introduced in the PR.
High
Learned best practice
Clarify user-facing status message
Make the user-facing message more specific and actionable so users understand what is happening and how to retry or proceed.
-puts 'installing ruby, this may take a minute'+puts 'Ensuring Ruby toolchain for local dev (this may take a minute)...'
Apply / Chat
Suggestion importance[1-10]: 6
__
Why:
Relevant best practice - Keep API and documentation accurate and consistent by providing clear, actionable user-facing messages that reflect actual behavior and next steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
The
./go rb:local_devcommand is builds everything so that all assets/code that needs to be generated in the build process is created so that any tests that need to be run can be run through RubyMine instead of just bazel for better debugging options.I have my RubyMine set to use the ruby binary stored in the bazel-selenium working directory.
For local Ruby development, if you want to run on RBE, you have to switch to jruby, and every time you change the ruby versions, RubyMine gets unhappy. Running
./go rb:local_devshould fix this, but for some reason it builds the ruby binary, but does not stage it in thebazel-selenium/ working directory. Adding a command that requires using the ruby binary forces it to be staged.PR Type
Enhancement
Description
Adds informative message during Ruby binary installation
Executes additional Bazel command to stage Ruby binary
Ensures Ruby binary is properly placed in working directory
Diagram Walkthrough
File Walkthrough
Rakefile
Add Ruby binary staging to local_dev taskRakefile
--dry-runflag for rubocop to forcestaging of Ruby binary
command