-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rust] fix support for Edge beta versions on Windows #16806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
bonigarcia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested it, but the code LGTM.
User description
💥 What does this PR do?
🔄 Types of changes
PR Type
Bug fix
Description
Fix Edge beta/dev/canary installation path detection on Windows
Use correct Program Files environment variable for unstable Edge versions
Improve logging messages to clarify Edge system path behavior on Windows
Simplify browser path resolution logic for Windows Edge installations
Diagram Walkthrough
File Walkthrough
edge.rs
Fix Edge Windows installation path selection logicrust/src/edge.rs
ENV_PROGRAM_FILESimport for unstable Edge versionsbased on Edge version stability
dynamically instead of always using x86 variant
lib.rs
Improve logging clarity for Edge Windows behaviorrust/src/lib.rs
behavior
downloaded
reducing nesting