Skip to content

[multibyte] Add multibyte array load instructions.#8504

Merged
brendandahl merged 5 commits into
WebAssembly:mainfrom
brendandahl:multibyte-array-load
Mar 25, 2026
Merged

[multibyte] Add multibyte array load instructions.#8504
brendandahl merged 5 commits into
WebAssembly:mainfrom
brendandahl:multibyte-array-load

Conversation

@brendandahl

@brendandahl brendandahl commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Prototype implementation of the new multibyte array proposal that reuses the existing memory instructions.

https://github.com/WebAssembly/multibyte-array-access/blob/944d79230b336442b1f0b3978da1908d54b9f230/proposals/multibyte-array-access/Overview.md

@brendandahl brendandahl requested a review from a team as a code owner March 20, 2026 18:57
@brendandahl brendandahl requested review from stevenfontanella and removed request for a team March 20, 2026 18:57
stevenfontanella
stevenfontanella reviewed Mar 20, 2026
View reviewed changes
Comment thread src/wasm-interpreter.h Outdated
Comment thread src/ir/effects.h Outdated
Comment thread src/wasm/wasm.cpp
Comment thread src/ir/cost.h
@stevenfontanella stevenfontanella requested review from a team and tlively and removed request for a team March 20, 2026 21:09
@stevenfontanella

stevenfontanella commented Mar 20, 2026

Copy link
Copy Markdown
Member

(Re-add binaryen reviewers for a second look)

tlively
tlively reviewed Mar 20, 2026
View reviewed changes
Comment thread src/ir/cost.h
Comment thread src/ir/effects.h Outdated
Comment thread src/ir/possible-contents.cpp Outdated
Comment thread src/wasm/wasm.cpp
Comment thread src/wasm-interpreter.h Outdated
kripken
kripken reviewed Mar 23, 2026
View reviewed changes

@kripken kripken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to do something for Precompute here, like #8511

We could also optimize loads from immutable data, like ArrayGet, but can leave that for later.

@brendandahl

brendandahl commented Mar 23, 2026

Copy link
Copy Markdown
Collaborator Author

I believe we need to do something for Precompute here, like #8511

We could also optimize loads from immutable data, like ArrayGet, but can leave that for later.

was just adding that... fdb61fa

@kripken

kripken commented Mar 23, 2026

Copy link
Copy Markdown
Member

Cool, that commit lgtm

@brendandahl brendandahl merged commit 86f0e8a into WebAssembly:main Mar 25, 2026
16 checks passed
@brendandahl brendandahl mentioned this pull request Apr 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken left review comments
@stevenfontanella stevenfontanella stevenfontanella approved these changes
@tlively tlively Awaiting requested review from tlively

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brendandahl @stevenfontanella @kripken @tlively