replace 'npx' with 'node' on test-playwright.js file'#55616
Merged
gziolo merged 1 commit intoWordPress:trunkfrom Nov 2, 2023
Merged
replace 'npx' with 'node' on test-playwright.js file'#55616gziolo merged 1 commit intoWordPress:trunkfrom
gziolo merged 1 commit intoWordPress:trunkfrom
Conversation
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @iamsadi22! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
gziolo
approved these changes
Nov 2, 2023
Member
gziolo
left a comment
There was a problem hiding this comment.
Good catch, thank you for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the error encountered while running playwright tests on Flywheel Local.
Why?
After running
test:e2e:playwrighton a Flywheel local setup, an error is encountered with the message: "sh: /Users/test/Local: is a directory."This error occurs because the plugin's absolute path is
"/Users/test/Local Sites/*****,"and the current command mistakenly removes the other parts of absolute path after space and interprets"Local"as a directory.This PR addresses the issue by replacing
npxwithnode, which resolves the error and allows the tests to run successfully.Is this the correct way to run test on Local by Flywheel?