Skip to content

Stylebook: add the Appearance -> Design submenu through admin_menu action#68174

Merged
ramonjd merged 2 commits into
WordPress:trunkfrom
fushar:fix-appearance-design
Dec 23, 2024
Merged

Stylebook: add the Appearance -> Design submenu through admin_menu action#68174
ramonjd merged 2 commits into
WordPress:trunkfrom
fushar:fix-appearance-design

Conversation

@fushar
Copy link
Copy Markdown
Contributor

@fushar fushar commented Dec 20, 2024

What?

This PR is an improvement to #66851.

Some plugins are triggering the admin_menu action directly to populate the admin menus of a site. Here, I am proposing that we add the Appearance -> Design submenu via that action instead of admin_init.

Testing Instructions

  1. Activate a Classic theme.
  2. Verify that you still see the Appearance -> Design submenu:
image

@fushar fushar requested a review from spacedmonkey as a code owner December 20, 2024 10:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: fushar <fushar@git.wordpress.org>
Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions Bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 20, 2024
@github-actions
Copy link
Copy Markdown

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @fushar! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@fushar
Copy link
Copy Markdown
Contributor Author

fushar commented Dec 20, 2024

cc: @youknowriad @jasmussen

Copy link
Copy Markdown
Member

@ramonjd ramonjd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this. LGTM

Changes to PHP files need a backport reference.

It looks like @tellthemachines has already got a draft up at so you could use WordPress/wordpress-develop#7865 as the backport reference.

Basically, it means adding this PR's URL to the existing md file: https://github.com/WordPress/gutenberg/blob/trunk/backport-changelog/6.8/7865.md?plain=1

After that, I think it's good to go 👍🏻

@fushar
Copy link
Copy Markdown
Contributor Author

fushar commented Dec 23, 2024

Thanks @ramonjd for the pointer; I've updated the PR as per your suggestion!

@ramonjd ramonjd merged commit ea7bc78 into WordPress:trunk Dec 23, 2024
@github-actions github-actions Bot added this to the Gutenberg 20.0 milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Style Book First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants