Select.Popup, Input: Expose anchor and rootRef props#76417
Closed
Select.Popup, Input: Expose anchor and rootRef props#76417
Select.Popup, Input: Expose anchor and rootRef props#76417Conversation
|
Size Change: 0 B Total Size: 6.89 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 8ac9a07. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/22974652340
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Expose an
anchorprop onSelect.Popupand arootRefprop onInput, allowing popup positioning against the full input container rather than the inner element.Why?
Base UI's
Positioneranchors to the trigger/input element by default. When anInputhas prefix or suffix slots, the inner<input>is narrower than the outerInputLayoutcontainer, so any popup positioned against it will be misaligned and too narrow.Select.Popupwraps the Base UIPositionerbut doesn't expose itsanchorprop, so there's currently no way to override the default anchor. Similarly,Inputforwards itsrefto the inner<input>element, giving consumers no way to reference the outerInputLayoutwrapper for use as an anchor.How?
Select.Popup: Accept ananchorprop and forward it to_Select.Positioner. This matches the existing Base UIPositionerAPI.Input: Add arootRefprop forwarded to the rootInputLayoutelement. The existingrefcontinues to target the inner<input>.Testing Instructions
No visual changes — these are new opt-in props with no effect when unused.