Navigation: Respect overlayMenu="always" in site view and isolated template part editing#76454
Closed
Navigation: Respect overlayMenu="always" in site view and isolated template part editing#76454
overlayMenu="always" in site view and isolated template part editing#76454Conversation
…editing modes When overlayMenu is set to 'always', the burger icon should always be shown including in site view (preview mode) and isolated template part editing. Previously, editorDisabledResponsive suppressed the responsive wrapper for all overlay modes in preview/isolated contexts, but this should only apply to 'mobile' (viewport-based) mode, not 'always' (explicit user choice). Co-authored-by: scruffian <275961+scruffian@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix burger icon inconsistency in navigation overlay
Navigation: Respect Mar 12, 2026
overlayMenu="always" in site view and isolated template part editing
jeryj
reviewed
Mar 12, 2026
| // This flag is intentionally ignored when overlayMenu is 'always', since that | ||
| // is an explicit user choice to always show the hamburger menu. | ||
| editorDisabledResponsive: | ||
| settings.isPreviewMode || !! settings?.[ isIsolatedEditorKey ], |
Contributor
There was a problem hiding this comment.
The issue is here.
- settings.isPreviewMode isn't the right check
- !! settings?.[ isIsolatedEditorKey ] returns true for any isolated editor, not just the navigation isolated editor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Navigation block's overlay is set to Always, the burger icon was only rendered correctly in the regular editor canvas — site view (preview panel) and isolated template part editing both showed the expanded navigation links instead.
Root cause
editorDisabledResponsiveistruein preview mode and isolated editing mode, and it was unconditionally suppressingisResponsive:This was intentional for
overlayMenu === 'mobile'(viewport-based collapse shouldn't apply inside the editor canvas), but incorrectly extended to'always', overriding an explicit user setting.Change
overlayMenu === 'never'— no burger, unchangedoverlayMenu === 'mobile'in preview/isolated — no burger, unchanged (viewport breakpoints don't apply in the editor)overlayMenu === 'always'— burger shown everywhere, including site view and isolated template part editingWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
translate.wordpress.org/home/REDACTED/work/_temp/ghcca-node/node/bin/node node i18n-cache/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.