Select: Support placeholder prop on Trigger#78076
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 7.92 MB ℹ️ View Unchanged
|
|
Flaky tests detected in a307d52. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/25530899575
|
ciampo
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a
placeholderprop to theSelect.Triggerprimitive, defaulting toSelect, and aligns placeholder styling with Base UI's built-in placeholder state.Also updates the Select stories to demonstrate a custom placeholder and a clearable
nullvalue option.Why?
Base UI now provides official placeholder handling for Select. Using that state directly keeps the wrapper behavior aligned with upstream and avoids relying on an empty-string item value as a placeholder convention.
How?
placeholderfromSelect.Triggerto Base UI'sSelect.Value.data-placeholderattribute for placeholder styling.Select.Itemvalues to benull, matching Base UI's clearable item pattern.Testing Instructions
Design System/Components/Form/Primitives/Select.Screenshots or screencast