Fix first-time contributor welcome for members and repeat PR authors - #89
Merged
Merged
Conversation
MaggieCabrera
approved these changes
Sep 22, 2026
Contributor
|
Thanks! |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #88
This adds two checks before the existing commit lookups:
author_association— skip when it'sOWNER,MEMBERorCOLLABORATOR. This is the field GitHub uses for its own badge, which the workflow wasn't reading at all. Maggie is a WordPress org member, so she reportsMEMBERand is now skipped, matching the missing badge.type:pr author:search — skip when the author has already opened a PR here. The workflow was only counting commits, and you have no commits until your first PR merges, so every PR opened before that merge was greeted as the first. Maggie opened three before any had merged; now only the earliest would have qualified.The commit checks stay below both, so contributors whose commits landed without a PR are still recognised.
Use of AI Tools
🤖 Co-authored with Claude Code