Add explanation for discarded modern image outputs#2518
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #2518 +/- ##
==========================================
- Coverage 69.14% 69.11% -0.03%
==========================================
Files 90 90
Lines 7723 7726 +3
==========================================
Hits 5340 5340
- Misses 2383 2386 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| <p class="description" id="perflab_modern_image_format_description"><?php esc_html_e( 'Select the format to use when generating new images from uploaded images.', 'webp-uploads' ); ?></p> | ||
| <p class="description" id="perflab_modern_image_format_description"> | ||
| <?php esc_html_e( 'Select the format to use when generating new images from uploaded images.', 'webp-uploads' ); ?> | ||
| <?php esc_html_e( 'Generated images may be discarded if the modern image format file is larger than the original uploaded image.', 'webp-uploads' ); ?> |
There was a problem hiding this comment.
Shouldn't this string be combined with the previous string?
There was a problem hiding this comment.
I kept them separate intentionally to avoid changing the existing translatable string, since that string may already have translations. This way, only the newly added sentence needs to be translated.
That said, I’m happy to combine them if the preferred approach here is to give translators the full sentence context in a single string.
See #2442.
Summary
Adds a short explanation to the Modern Image Formats setting to clarify that generated AVIF/WebP images may be discarded when the generated file is larger than the original upload.
Testing
npm run lint-php.